Skip to content

ALSA: Keep the active input channels in sync with the callback's channel array - #1706

Draft
emezeske wants to merge 1 commit into
juce-framework:developfrom
emezeske:pr/alsa-input-channel-minimum
Draft

ALSA: Keep the active input channels in sync with the callback's channel array#1706
emezeske wants to merge 1 commit into
juce-framework:developfrom
emezeske:pr/alsa-input-channel-minimum

Conversation

@emezeske

@emezeske emezeske commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Opening an ALSA capture device whose minimum channel count is higher than the number of input channels selected crashes on the audio thread, in the input level meter. To reproduce, open a capture device whose ALSA minimum is 2 channels (a dsnoop device in my case) with only the first input channel enabled.

getActiveInputChannels() ends up reporting more channels than the audio callback is actually handed pointers for. open() fills inputChannelDataForCallback and currentInputChans together in one loop, and then widens currentInputChans to minChansIn afterwards, so the bitset gains a bit with no matching entry in the channel array. AudioDeviceManager sizes CallbackMaxSizeEnforcer's stored channel vectors from getActiveInputChannels(), fills in only the channels the device passes, and forwards the rest as null pointers, which is what then crashes in the meter.

This moves the widening up so that it applies to inputChannels before the loop runs, which is how the output path a few lines below already does it, and the two stay in agreement. A request for no input channels at all is left alone rather than being widened to the minimum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant