AudioDeviceManager: Fix a hang when a device reports a zero buffer size - #1703
Open
emezeske wants to merge 1 commit into
Open
AudioDeviceManager: Fix a hang when a device reports a zero buffer size#1703emezeske wants to merge 1 commit into
emezeske wants to merge 1 commit into
Conversation
emezeske
marked this pull request as ready for review
August 10, 2026 20:06
Collaborator
|
This pull request has been mentioned on The JUCE Forum. There might be relevant details there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The audio thread spins forever and the application stops producing audio, when a device reports a current buffer size of 0. The JACK backend does this while its client is unavailable, so an ordinary mid-reconfiguration moment is enough to trigger it.
CallbackMaxSizeEnforcer's chunking loop computes a block length of 0 from that and never advances.
With this change the enforcer emits a silent block instead and recovers on the next audioDeviceAboutToStart(), which restores the real block size.