Skip to content

JACK: Fail AudioIODevice::open() if the client can't be activated #1702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emezeske wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −1
Open

JACK: Fail AudioIODevice::open() if the client can't be activated #1702

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion modules/juce_audio_devices/native/juce_JackAudio_linux.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,16 @@ class JackAudioIODevice final : public AudioIODevice
juce::jack_on_shutdown (client, shutdownCallback, this);
juce::jack_on_info_shutdown (client, infoShutdownCallback, this);
juce::jack_set_xrun_callback (client, xrunCallback, this);
juce::jack_activate (client);

// If the client can't be activated, fail the whole open call:
// reporting success here would produce a device that appears to be
// running but never invokes its callback.
if (juce::jack_activate (client) != 0)
{
lastError = "Failed to activate JACK client";
return lastError;
}

deviceIsOpen = true;

if (! inputChannels.isZero())
Expand Down