Add AssumeRole error cache (Modernized #200)#397
Merged
Conversation
|
coverage: 16.936% (+1.7%) from 15.208% — feature/200-assumerole-error-cache into main |
jtblin
force-pushed
the
feature/200-assumerole-error-cache
branch
3 times, most recently
from
b29d698 to
89a8703
Compare
When AssumeRole is successful, the success is cached for (by default) 15 minutes. On failure, there is no cache. In cases of misconfiguration, this can result in a large number of AssumeRole calls against the AWS API, which, in extreme cases, can result in API rate limiting, causing other applications in the AWS account to experience failures. This adds a negative cache on AssumeRole to prevent error cases from spamming the API.
jtblin
force-pushed
the
feature/200-assumerole-error-cache
branch
from
4c44c71 to
e65cb31
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally proposed by @schleyfox in #200.
This PR adds a negative cache on AssumeRole to prevent error cases from spamming the AWS API. This is set to 0 by default to preserve existing behavior, but a value of 30 seconds to 1 minute would be reasonable.
Modernization changes:
main.iam.go,server.go, andmappings/mapper.go.externalIDsupport.