Skip to content

Add --metadata-protection#234

Open
arkadiyt wants to merge 1 commit into
jtblin:mainfrom
arkadiyt:atetelman--metadata
Open

Add --metadata-protection#234
arkadiyt wants to merge 1 commit into
jtblin:mainfrom
arkadiyt:atetelman--metadata

Conversation

@arkadiyt

Copy link
Copy Markdown

Adds a --metadata-protection flag for #212

@arkadiyt arkadiyt force-pushed the atetelman--metadata branch from 6885a63 to e71b053 Compare October 22, 2019 07:08
@coveralls

coveralls commented Oct 22, 2019

Copy link
Copy Markdown

Coverage Status

Coverage increased (+17.04%) to 36.519% when pulling 295d602 on arkadiyt:atetelman--metadata into c39e3cb on jtblin:master.

@SharpEdgeMarshall

Copy link
Copy Markdown
Collaborator

lgtm but please add tests

@arkadiyt arkadiyt force-pushed the atetelman--metadata branch 3 times, most recently from a7ffdfb to bd4ab8e Compare November 4, 2019 06:06
@arkadiyt

arkadiyt commented Nov 4, 2019

Copy link
Copy Markdown
Author

@SharpEdgeMarshall done

@arkadiyt arkadiyt force-pushed the atetelman--metadata branch from bd4ab8e to 295d602 Compare November 4, 2019 06:21
@arkadiyt

Copy link
Copy Markdown
Author

Friendly bump - I'm doubling kube2iam's test coverage here

@joshbranham

Copy link
Copy Markdown

bumping this, seems like a real easy security win here. Would love to see this moved forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants