Enhance validation coverage for string formats with robust and portable edge cases#880
Closed
OmSwainSupreme wants to merge 2 commits intojson-schema-org:mainfrom
Closed
Enhance validation coverage for string formats with robust and portable edge cases#880OmSwainSupreme wants to merge 2 commits intojson-schema-org:mainfrom
OmSwainSupreme wants to merge 2 commits intojson-schema-org:mainfrom
Conversation
Member
|
The Please familiarize yourself with the layout of this test suite and the standards we follow, by consulting its documentation e.g. README.md, before submitting further patches, and propose your changes in an issue first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Several string-based formats lacked comprehensive validation for actual string values and edge cases.
Most existing tests primarily focus on non-string inputs, leaving gaps in real-world validation coverage.
Solution
This PR enhances validation coverage by adding detailed test cases for multiple string formats, including:
Improvements
Impact
Improves robustness, correctness, and cross-implementation consistency of the JSON Schema test suite.
Notes
Care was taken to avoid implementation-specific behavior and ensure compatibility across different validators.