Remove meta-schema tests#873
Conversation
It's both, though. These tests were originally included as a stop-gap to test invalid schemas. If we remove these, we need a replacement for that function. I don't feel right just removing them. |
That's not what we decided. Retrieving
We really wouldn't lose much. There are three tests affected. One is What if I setup meta-schema testing in the spec repo instead and transfer those two relevant tests over there? Moving it to the spec repo makes more sense than the test suite because that's where we develop the meta-schemas. |
|
Here's the meta-schema test PR json-schema-org/json-schema-spec#1692 |
Some tests reference the meta-schema. Arguably we shouldn't do that. These test suites aren't for testing the meta-schema and we've removed such tests in the past. For v1, this pattern is problematic because
https://json-schema.org/v1is just a dialect identifier, not a mea-schema identifier.This removes meta-schema tests for v1. The reason for removing these tests applies to other dialects as well, but it's only necessary for v1. Should we clean up the other dialect test suites as well?