Add battery voltage, current, power, and temperature sensors - #11
Merged
Conversation
* fix: read battery packet measurements * test: cover battery packet telemetry * feat: add battery temperature sensor
battery_power got an entry but battery_voltage, battery_current, and battery_temperature did not, so they were falling back to the description name instead of the translation-driven path used by every other sensor. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebase of #9 (by @turbozv) onto current main, plus a small follow-up fix.
host_packet_data_jdbTSL property, consistent with existing struct-sensor patterns.strings.jsontranslation entries forbattery_voltage,battery_current, andbattery_temperature(onlybattery_powerhad one in the original PR).Closes #9.
Test plan
pytest— all 64 tests pass (43 existing + 21 new)ruff checkclean🤖 Generated with Claude Code