live-viewer: expose the impl to the console#313
Merged
Conversation
domenic
reviewed
Feb 4, 2026
domenic
left a comment
domenic
left a comment
Member
There was a problem hiding this comment.
Seems reasonably. Would you mind:
- Renaming to
whatwgURL. (It seems presumptuous to claimwindow.whatwg.) - Adding a source comment explaining why this is useful so I don't just delete it in 6 months.
- Maybe, updating index.html with some paragraph at the bottom explaining that the package's main module is available at
window.whatwgURLif you want to play around with it in the console.
Sorry, I know this turns a quick drive-by GitHub edit into more of a chore. I'll take care of these it's too much trouble, just let me know.
domenic
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
can help debugging by seeing the inner struct values