Skip to content

Features/extend aa score#294

Merged
jpquast merged 10 commits into
developerfrom
features/extend_aa_score
Mar 3, 2026
Merged

Features/extend aa score#294
jpquast merged 10 commits into
developerfrom
features/extend_aa_score

Conversation

@lukasvonziegler

Copy link
Copy Markdown
Collaborator
  • Added method selection to the aa_score calculations (now user can select between existing "multiplicative" (now set to be default method if not specified) and new "additive" method.
  • Added min-max normalization to the aa_score. An additonal column will be cratead in the results df with normalized scores, non-normalized scores are still exported using the expected column name

@lukasvonziegler lukasvonziegler requested a review from jpquast March 2, 2026 15:46

@jpquast jpquast left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you implement the two documentation changes.
Can you also still include the fix for issue #290 in this PR.
Thank you!

Comment thread R/calculate_aa_scores.R Outdated
Comment thread NEWS.md Outdated
lukasvonziegler and others added 3 commits March 3, 2026 12:40
Co-authored-by: Jan-Philipp Quast <59307482+jpquast@users.noreply.github.com>
Co-authored-by: Jan-Philipp Quast <59307482+jpquast@users.noreply.github.com>
@lukasvonziegler

Copy link
Copy Markdown
Collaborator Author

added suggested docs improvements and fix for #290

@jpquast jpquast self-requested a review March 3, 2026 12:49

@jpquast jpquast left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some more issues.

Comment thread R/calculate_aa_scores.R
Comment thread R/calculate_aa_scores.R
lukasvonziegler and others added 3 commits March 3, 2026 16:31
Co-authored-by: Jan-Philipp Quast <59307482+jpquast@users.noreply.github.com>
Co-authored-by: Jan-Philipp Quast <59307482+jpquast@users.noreply.github.com>
@jpquast jpquast self-requested a review March 3, 2026 19:22

@jpquast jpquast left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@jpquast jpquast merged commit 3a25a4c into developer Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants