Vexserial#13
Open
gherlein wants to merge 4 commits into
Open
Conversation
Owner
|
This has some issues and I'm not sure should ever really be part of the main ConVEX project anyway. There's already lots of custom programs that modify the core firmware and utilize it in a different way, this sort of falls into that category. You are opening the console serial port twice, once in main, again in vexuser. The two threads reading characters will conflict. I see what you are trying to do and will suggest an alternative way, probably next week at this point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cleaned up the other changes - base vexserial support for a non-shell, user created interactive serial protocol