Skip to content

[Security Solution] Remove exceptions_list, author and license from Diffable Rule#2

Open
jpdjere wants to merge 1 commit into
extend-upgrade-perform-endpoint-logicfrom
remove-diffable-rule-fields
Open

[Security Solution] Remove exceptions_list, author and license from Diffable Rule#2
jpdjere wants to merge 1 commit into
extend-upgrade-perform-endpoint-logicfrom
remove-diffable-rule-fields

Conversation

@jpdjere

@jpdjere jpdjere commented Oct 15, 2024

Copy link
Copy Markdown
Owner

Resolves: elastic#196213

Summary

Excludes the fields exceptions_list, author and license from the DiffableRule definition.

This will:

  • prevent them from appearing in the Three Way Diff component
  • prevent them from being able to be passed as a value in the fields object of the /upgrade/_perform endpoint to set a specific pick_version for it (NOTE: the current logic already forces exceptions_list to upgrade to the CURRENT version, but removing it from DiffableRule, will completely remove the from the payload schema, and the endpoint will then throw a validation error if included, rather than silently ignoring it)

For maintainers

@jpdjere jpdjere self-assigned this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant