Fixes and Tweaks for Slurm and the Web Component#2
Open
dmf24 wants to merge 47 commits into
Open
Conversation
… run and see what happens
… proctools.py with process wrappers
…ry directory can be specified with standard unix semantics
…cratch directory for now until I can clean up the rest of the string-concatenated paths
…e defaults to use corecop.hms.harvard.edu
O2 and o2web compatibility changes
Write SMTP exception to the log
Replace sender noreply@kirschner.med.harvard.edu with pesha@hms.harva…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are changes made to achieve the following:
Here's a summary of most of the changes in more detail:
sbatchmethod to the slurm job runner class, and used sbatch instead of srun for the default job command.waitlogic. All of the python subprocess calls will block and wait for the results of the command. For the initial control job submission, sbatch will NOT be configured to wait. The python subprocess call blocks, but only until it gets theSubmitted batch job ......result. For each subsequent step in the pipeline,sbatchwill be configured to wait (--wait) and so the subprocess call will block until the job finishes..sofile. I compiled a fresh 2.7 version, and added it to the corecop virtualenv, making kjbuckets available no matter what directory you import from. This virtualenv is configured to be activated automatically by the webserver and inherited by the php scripts that initially invoke python. (Of course, this virtualenv could also be activated by code).file_paths.py, to support allowing the site to run from a docroot other than/www/kirschner.med.harvard.edu/docroot. Also removed the hard-coded paths to python and perl and configured them to run from the environment, allowing use of theperl/5.24.0module and a custom python virtualenv rather than system binaries.os.path.joinfunction. I don't think I caught them all. The goal is to support setting directories as either/path/to/directoryor/path/to/directory/. Currently, the scratch directory must be specified with a trailing slash, or else the application will try to write files to/path/to/directoryfilename.log.date_default_timezone_set("America/New_York");to clear some error spam on the results page./n/groups/kirschner_www/corecopinstead of/n/scratch2/cra. This is only because scratch2 is not currently mounted on the web servers. I also made this configurable with an environment variable if or when we are able to make scratch2 available on the webservers.<corecop>/analyzers/fasta_checker_for_crap.plto/www/kirschner.med.harvard.edu/docroot/genomes/code/fasta_checker_for_crap.pl. This is probably not necessary, the FASTACHECKER_PATH can be changed back to hardcoded. This was a change I made while troubleshooting and did not revert as it is stillw orking.These are outstanding issues unrelated to any issues with slurm submission or web hosting:
/). Minor issue but I think it's close to fixed.