Classfile-based Java API: inherited members + de-reflection option (#837)#2
Open
jozanek wants to merge 5 commits into
Open
Classfile-based Java API: inherited members + de-reflection option (#837)#2jozanek wants to merge 5 commits into
jozanek wants to merge 5 commits into
Conversation
jozanek
force-pushed
the
feat/classfile-java-api-phase3
branch
from
a160351 to
ccc13af
Compare
jozanek
force-pushed
the
feat/classfile-java-api-unloadable
branch
from
eec8263 to
f587ec7
Compare
…1729) Co-authored-by: Jozef Koval <jozef.koval@beone.com>
jozanek
force-pushed
the
feat/classfile-java-api-phase3
branch
from
ccc13af to
e7ddd36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1. Third step of the classfile-based Java API work.
Completes the classfile path to full structural parity with reflection:
IncOptions.classfileJavaApi(off by default) routes all Java classes through the classfile path, removing the reflective loading behind IllegalArgumentException thrown in analysis of Java compiled with --add-exports sbt/zinc#837/Analysis of javac compiled classes can cause static initializers to run sbt/zinc#151/ClassToAPI.loadInnerClass NPEs on JDK 21+ when a Java class extends Thread (regression in 2.0.0-M17) sbt/zinc#1697. Per-invocation option, not a global system property.Validated by a differential audit asserting structural parity with
ClassToAPI(member set, kind, access, arity, varargs, type-params; declared + inherited nested classes) plus an end-to-end incremental test. Whole-class hashes intentionally differ (accepted one-time re-hash); flipping the default is a separate maintainer decision.