fix(igpsport): paginate activity list and parse dotted start times#51
Merged
Conversation
queryMyActivity returns at most 20 rows per page, so a single request silently capped syncs regardless of --max-activities. Co-authored-by: Cursor <cursoragent@cursor.com>
Some accounts return date-only YYYY.MM.DD times from iGPSPORT. Unparsed starts triggered a 365-day fallback range, inflating the already-uploaded count from unrelated intervals.icu activities. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
queryMyActivityrequests so syncs can list more than 20 rides (fixes iGPSPORT sync maxes at 20 #49).YYYY.MM.DDstart times returned by some iGPSPORT accounts, so the intervals.icu dedup window matches the listed rides instead of falling back to a full year.Test plan
uv run pytest tests/test_igpsport_core.py(pagination + dotted-date parsing)uv run pytest(full suite)--max-activities 30lists 30 rides and reports a realistic already-uploaded count/date range