feat(api): replace dict by request objects for pt APIs#95
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors public transportation API methods to use typed request objects instead of dictionaries for parameter passing. The change improves type safety and reduces code duplication by consolidating filter logic in a base class.
- Introduces new request classes for each PT entity type (VehicleJourney, StopPoint, StopArea, Route, etc.)
- Refactors API client methods to accept a single
BasePTEntityRequestparameter instead of multiple individual parameters - Updates all tests to instantiate and pass the appropriate request objects
Reviewed Changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
navitia_client/entities/request/base_entity_request.py |
Adds to_filters() method to convert request object to dictionary |
navitia_client/entities/request/public_transportations/*.py |
New request classes for each PT entity type |
navitia_client/entities/request/public_transportations/__init__.py |
Exports all request classes |
navitia_client/entities/request/public_transportations/___init__.py |
Duplicate file with incorrect filename (triple underscores) |
navitia_client/client/apis/public_transportation_apis/*.py |
Refactored to use request objects instead of individual parameters |
tests/client/apis/public_transportation_apis/*.py |
Updated to instantiate and use new request objects |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Changelog: * Add requests objects for pt APIs * Update functions used to call APIs to use requests objects rather than dictionnaries * Update tests
jonperron
force-pushed
the
feat/request-ptobjects-refactor
branch
from
6137b2c to
ac72f4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: