feat(journeys): add support for some Valhalla parameters#87
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for additional journey search parameters in the Navitia API client, including parking modes and Valhalla routing preferences. The changes enable users to customize journey calculations with car parking options and fine-tune biking/walking route preferences.
Key changes:
- Added
ParkModeenum with three values: NONE, ON_STREET, and PARK_AND_RIDE - Added 8 new optional parameters to journey methods:
park_mode,is_journey_schedules, and 6 Valhalla routing preference parameters - Updated documentation to reflect the new parameters
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| navitia_client/entities/journey.py | Defines new ParkMode enum for car parking options |
| navitia_client/entities/init.py | Exports ParkMode for external use |
| navitia_client/client/apis/journeys_apis.py | Adds new parameters to all three journey API methods with corresponding filter logic |
| docs/api_support/journeys.md | Updates method signatures to include new parameters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Changelog * Add park_mode and is_journey_schedules parameters * Add some Valhalla parameters: * bike_use_hills * walking_use_hills * bike_avoid_bad_surfaces * walking_step_penalty * bike_maneuver_penalty * bike_use_living_streets * Update test
jonperron
force-pushed
the
feat/update_journeys_api
branch
from
bb9efe1 to
8cb8091
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Fix #83