feat(pagination): add missing parameters#85
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds pagination parameters to multiple schedule and arrival/departure API methods to enable better control over result sets. The changes add count and start_page parameters to allow callers to specify the maximum number of results and starting page for pagination.
- Adds
countparameter (default: 10) to limit the number of results returned - Adds
start_pageparameter (default: 0) to specify the starting page for pagination in schedule APIs - Updates function signatures, documentation, and parameter dictionaries consistently
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| terminus_schedules_apis.py | Adds count and start_page parameters to both list methods |
| stop_schedules_apis.py | Adds count and start_page parameters to both list methods |
| route_schedules_apis.py | Adds count and start_page parameters to both list methods |
| departure_apis.py | Adds only count parameter to both list methods |
| arrival_apis.py | Adds only count parameter to both list methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Changelog: * Update Arrivals API * Update Departures API * Update Stop Schedules API * Update Route Schedules API * Update Terminus Schedules API * Update documentation
jonperron
force-pushed
the
feat/missing_arguments
branch
from
3be6a5f to
8a1dd99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog:
Fix #81