fix: avoid integer overflow when computing percentage for large sample counts#367
Open
SAY-5 wants to merge 1 commit into
Open
fix: avoid integer overflow when computing percentage for large sample counts#367SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #170.
When a stack has a very large sample count (e.g.
offwaketimeoutput with values around 2.4e17),100 * samplesoverflowed the integer type and panicked with "attempt to multiply with overflow" atsrc/flamegraph/mod.rs. The same applied to100 * deltain the differential path.Performing the
* 100in floating point (100.0 * x as f64) avoids the overflow. Output is unchanged for normal-magnitude inputs.Added a regression test that feeds large sample counts through
from_linesand asserts it does not panic.