feat: background notifications for tool approval - #13
Draft
jongracecox wants to merge 3 commits into
Draft
Conversation
Send macOS notifications when background sessions transition to tool approval state while user is attached to a tmux session. Monitors all project sessions via a daemon thread, skipping the currently-attached session.
Switch from osascript to terminal-notifier for proper macOS notification center integration. Include Claude's explanation text in notifications so users know what tool approval is needed. Add skip option to installer prompt and FUJIMOTO_SKIP_NOTIFICATIONS env var to disable notifications entirely. Guard monitor startup so it only runs when terminal-notifier is available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WAITING_FOR_TOOL_APPROVALwhile the user is attached to a different tmux sessionterminal-notifierfor proper notification center integration (auto-install prompt on first run, skippable)FUJIMOTO_SKIP_NOTIFICATIONS=1env var to disable notifications entirelyNote: This is a draft — may need more testing and iteration on notification UX.
Test plan
fujimoto, verify terminal-notifier install prompt appears with Install/Skip/Quit optionsFUJIMOTO_SKIP_NOTIFICATIONS=1, verify install prompt is skipped