Prop init bug - #8
Open
PerfProf wants to merge 4 commits into
Open
Conversation
Uncovered a defect with original code that does not initialize the class property Fsm->m_num_timed_transtions.
Owner
|
Thanks for this. Especially that nasty initialization bug. I should be getting my motherboard back in next week so will be able to fix/merge everything in the issue list and made a release. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The constructor for the Fsm class failed to mention the m_num_timed_transtitions in the member initialization list.
Since this is an initialization problem the bug may not demonstrate itself because the likely intial value of zero is also the intended default value. Adding debug statements caused the problem to go away in my test sketches.
I added two simple test cases to verify basic functionality of the FSM.