Skip to content

Add ntt.net record to example/jwhois.conf. Issue #3.#11

Open
mykola-kyryk wants to merge 1 commit into
jonasob:masterfrom
mykola-kyryk:verio-update
Open

Add ntt.net record to example/jwhois.conf. Issue #3.#11
mykola-kyryk wants to merge 1 commit into
jonasob:masterfrom
mykola-kyryk:verio-update

Conversation

@mykola-kyryk

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread example/jwhois.conf

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems as if it would match the same as the previous verio regexp. Are there any examples of an ntt netblock record? The regexp needs to be updated accordingly.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it is really hard to read diff in the issue #3. Can you attach to an
issue as a file or email it to me?
On Jan 20, 2015 10:31 PM, "Jonas Öberg" notifications@github.com wrote:

In example/jwhois.conf
#11 (diff):

@@ -56,6 +56,11 @@ whois-servers {
"^!?NET(BLK)?-VRIO(-[A-Z0-9]+)+$" = "rwhois.verio.net";

#
  • Catch ntt.net netblock records

  • "^!?NET(BLK)?-VRIO(-[A-Z0-9]+)+$" = "rwhois.gin.ntt.net";

This seems as if it would match the same as the previous verio regexp. Are
there any examples of an ntt netblock record? The regexp needs to be
updated accordingly.


Reply to this email directly or view it on GitHub
https://github.com/jonasob/jwhois/pull/11/files#r23253032.

robert-scheck added a commit to robert-scheck/jwhois that referenced this pull request Mar 1, 2015
@robert-scheck

Copy link
Copy Markdown
Contributor

After spending quite a nice amount of time with this issue, I figured out this:

$ host rwhois.verio.net
Host rwhois.verio.net not found: 3(NXDOMAIN)
$ 

And Wikipedia says "In early 2000 Verio was sold to NTT" at https://en.wikipedia.org/wiki/Verio thus the WHOIS server needs to be changed from rwhois.verio.net to rwhois.gin.ntt.net simply. The rwhois.gin.ntt.net returns the right results for Verio objects. Patch suggested as part of pull request #17.

@jonasob jonasob left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The new regex pattern is identical to the existing Verio pattern:

# Existing (line ~55):
"^!?NET\\(BLK\\)?-VRIO\\(-[A-Z0-9]+\\)+$" = "rwhois.verio.net";

# Added (new):
"^!?NET\\(BLK\\)?-VRIO\\(-[A-Z0-9]+\\)+$" = "rwhois.gin.ntt.net";

Both use the VRIO pattern. Since Verio was acquired by NTT, this duplicate regex means the first match wins and the second is dead code. This should either:

  • Replace the existing Verio entry with the NTT one (if NTT's rwhois server has fully taken over), or
  • Use a different regex that matches NTT-specific netblock records (e.g. something with NTT instead of VRIO).

Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants