Trail map feedback: dark-mode popups, stop rendering, map resize + home-as-trip-start and campsite booking clarity#30
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses trail-map user feedback for the planning page, plus two feature asks from the same
report: trips that start from home, and clearer campsite booking info.
Plan-map bug fixes
color: fgtoken made popup text near-white in dark mode (white-on-white). Popups are nowrestyled per color mode via
.maplibregl-popup-content/-tiptoken rules in the theme'sglobalCss; inline popup HTML uses Chakra CSS variables instead of hard-coded hex.MapTripCanvas/TripMapdropped the render with no retry whenever
isStyleLoaded()was momentarily false. It nowretries on the next
idleevent.map.resize(); when added stops made thebuilder column overflow, the scrollbar narrowed the container while the GL canvas kept its
stale width. Both plan maps now run a
ResizeObserver→map.resize().Home location as the trip start point (ADR-074)
(:User)-[:LIVES_AT]->(:Home)(migration 028), captured via the newset_home_locationranger tool (confirm-before-save), a Home card on/me(free text orbrowser geolocation), all geocoded server-side through the existing ORS adapter
(
geocode/reverseGeocodeon the same key — no new vendor).(default on). Fixes a latent bug:
:Trip.startPointwas written as a bare map param, whichNeo4j rejects — it's a real spatial
point()now.:Tripprops computed byrecomputeSegments(the origin is nota
:Stop;DRIVE_TOstays stop-to-stop), shown in TripBuilder, counted in metrics, drawn onthe plan/shared maps (⌂ marker + extended route), and exported in the GPX.
/exploredistance sort + "~N mi from home"card line, a "From home" stat on park pages, and a home pin in the
/map"Your map" overlay.Campsite booking clarity (ADR-075)
lib/camp-booking.ts#bookingSignalclassifier (reservation / first-come / mixed /unknown) with shared badge wording + palette, consumed by: a prominent callout on the
campground detail page, a clear badge on finder cards (replacing
R42 · FCFS18), and abooking badge in the ranger chat campground cards (previously no signal). Unknown degrades to
"Check on recreation.gov ↗" — absence of data is never rendered as bookable or full.
maxPeople,campfireAllowed,shade) via the RIDB attributemapper; already-synced facilities backfill on changed RIDB content or a forced re-run.
Group trip planning from the same feedback is validated but deferred (noted in ADR-074).
Deploy notes
pnpm db:migrate(migration 028::Homeuniqueness constraint).ORS_API_KEY.Testing
pnpm typecheckclean;pnpm test:unit112 files / 1008 tests passing (new coverage:bookingSignal, RIDB attr parsing, home-defaulted trip origin, memory-block home line).pnpm buildsucceeds;pnpm exec eve info— 0 errors / 0 warnings.markup changed.