Skip to content

Set /ranks default to atlantis, normalize slash choices, and simplify tests#41

Merged
johnvictorfs merged 1 commit into
masterfrom
codex/update-ranks-to-use-select-options
Feb 10, 2026
Merged

Set /ranks default to atlantis, normalize slash choices, and simplify tests#41
johnvictorfs merged 1 commit into
masterfrom
codex/update-ranks-to-use-select-options

Conversation

@johnvictorfs

Copy link
Copy Markdown
Owner

Motivation

  • Make the /ranks slash option a proper selectable choice with normalized internal values and ensure the default selection is atlantis for a better UX.
  • Add missing command descriptions to hybrid commands so metadata is complete.
  • Remove brittle tests that assert exact description strings to avoid fragile test behavior.

Description

  • Updated bot/cogs/clan.py to use normalized lowercase slash choice values (atlantis, argus) and set the ranks command default parameter to "atlantis" by changing the app_commands.Choice values and the function signature default. (ranks in Clan cog)
  • Added description metadata to hybrid commands that were missing it: aplicar (aplicar_role) in bot/cogs/authentication.py and atlantisbot in bot/cogs/chat.py using the hybrid command decorator.
  • Simplified tests by removing hardcoded description assertions from tests/test_atlantisbot_command.py and tests/test_aplicar_command.py and updating tests/test_ranks_command.py to assert the slash choice names/values now use lowercase and to add test_ranks_default_clan_is_atlantis that asserts the default is "atlantis".

Testing

  • Ran pytest -q, which passed: 7 passed in 0.65s.

Codex Task

@johnvictorfs
johnvictorfs merged commit bdc16d1 into master Feb 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant