Set /ranks default to atlantis, normalize slash choices, and simplify tests#41
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
/ranksslash option a proper selectable choice with normalized internal values and ensure the default selection isatlantisfor a better UX.Description
bot/cogs/clan.pyto use normalized lowercase slash choice values (atlantis,argus) and set therankscommand default parameter to"atlantis"by changing theapp_commands.Choicevalues and the function signature default. (ranksinClancog)descriptionmetadata to hybrid commands that were missing it:aplicar(aplicar_role) inbot/cogs/authentication.pyandatlantisbotinbot/cogs/chat.pyusing the hybrid command decorator.tests/test_atlantisbot_command.pyandtests/test_aplicar_command.pyand updatingtests/test_ranks_command.pyto assert the slash choice names/values now use lowercase and to addtest_ranks_default_clan_is_atlantisthat asserts the default is"atlantis".Testing
pytest -q, which passed:7 passed in 0.65s.Codex Task