Make member role application command a hybrid slash command#40
Merged
johnvictorfs merged 1 commit intoFeb 8, 2026
Merged
Conversation
aplicar to member-role flow and keep ranks behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
aplicarcommand while PvM apply flows (Raids/AoD) must remain prefix-only to avoid changing unrelated behaviors.rankshybrid behavior and keep a helpful suggestion when invoked via prefix for a better UX.Description
@commands.hybrid_command(name="aplicar", aliases=["role", "membro", "aplicar_role"])inbot/cogs/authentication.py.@commands.command("raids", aliases=["aplicar_raids"])inbot/cogs/chat.pyso PvM apply commands remain unchanged.ranksas a hybrid command and preserved the prefix-tip by checkingif getattr(ctx, "interaction", None) is None: await ctx.send("Dica: use o comando de barra/ranks...")inbot/cogs/clan.py.tests/helpers.pywith additional lightweight stubs and amake_authentication()helper, replaced the aplicar test to assertauthentication.aplicar_roleis aHybridCommand, and kept/addedtests/test_ranks_command.pyto validaterankshybrid behavior and the prefix suggestion.Testing
pytest -q, which completed successfully with5 passed.Codex Task