Implement firefox container tab support#263
Open
whi-tw wants to merge 1 commit into
Open
Conversation
Firefox can have container tabs enabled, and an extension exists that will allow routing urls with a specific format into these containers [Open External links in a container](https://addons.mozilla.org/en-GB/firefox/addon/open-url-in-container/). If configured in a `handler`, rewrite the outgoing URL into this format and open that. This has an improvement over using a rewrite rule, in that the config can be kept DRY, and container selection logic is left to the handler. Example configuration: ```js handlers: [ { // Some work site match: "https://some-site.com/*", browser: { name: "Firefox", container: "Work", }, }, ], ```
|
I really need this one, no way we can have it/ |
Contributor
|
Disclaimer: I'm not a maintainer. Firefox's Containers are interesting, but this feature is tied to an extension, that may or may not survive (as of today, the linked extension code is 6 years old), so I'm balanced. I do agree this is useful, but this looks wrong to rely on a non browser feature. I found there is a maintained fork https://github.com/kud/webextension-container-scheme Another avenue that might be worth exploring is the URL rewriter, which do not require changes in Finicky, just in your config . That's what I do for my slack urls. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefox can have container tabs enabled, and an extension exists that will allow routing external URLs with a specific format into these containers Open External links in a container.
This change implements logic so if configured in a
handler, the outgoing URL is converted into this format when the browser is called.This has an improvement over using a rewrite rule, in that the config can be kept DRY, and container selection logic is left to the handler. An example of such a rewrite rule implementation is here: #211 (comment).
Example configuration: