Conversation
Default bind address changed to 127.0.0.1 (localhost only) to prevent unintended network exposure. New --password flag enables HTTP Basic Auth via a before_request hook in Flask. Warns when binding to 0.0.0.0 without a password set. Closes #19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
127.0.0.1(localhost only) via new--hostflag, preventing unintended network exposure--passwordflag enables HTTP Basic Auth on all web routes using abefore_requesthook0.0.0.0without--passwordsetDesign
HTTP Basic Auth chosen over bearer tokens because MJPEG streaming uses
<img src="/stream">which cannot set custom headers — Basic Auth is native to the browser and works transparently. Any username accepted, only password is checked.Usage
Test plan
/,/status,/events)--passwordnot set--hostdefaults to127.0.0.1start_web_server()respects host parameterCloses #19