fix: render all stack items on Emacs 29+ (header-line-format)#39
Open
vvutkin wants to merge 1 commit into
Open
fix: render all stack items on Emacs 29+ (header-line-format)#39vvutkin wants to merge 1 commit into
vvutkin wants to merge 1 commit into
Conversation
Emacs 29+ moved the "--- Emacs Calculator Mode ---" separator from buffer text to header-line-format. The unconditional forward-line 1 was skipping the deepest stack item instead of the header. Now checks for the text header before skipping, so the fix is backwards-compatible with older Emacs versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emacs 29+ moved the "--- Emacs Calculator Mode ---" separator from
buffer text to header-line-format. The unconditional forward-line 1
was skipping the deepest stack item instead of the header.
Now checks for the text header before skipping, so the fix is
backwards-compatible with older Emacs versions.