Very small PR: jQuery.isFunction is removed in jQuery 4.0+#195
Open
Gogowitsch wants to merge 1 commit into
Open
Very small PR: jQuery.isFunction is removed in jQuery 4.0+#195Gogowitsch wants to merge 1 commit into
Gogowitsch wants to merge 1 commit into
Conversation
Gogowitsch
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals: why merge this PR?
Make hoverIntent compatible with Drupal 11.
Solution details
The Drupal module Responsive and off-canvas menu suggests to put this repo in the /libraries directory of the Drupal installation. With Drupal 11, the hoverIntent plugin is called with jQuery 4.
I have opened an issue with the affected Drupal module, just to inform their user base. However the fix needs to happen here.
I found the same problem and its solution in the Webform issue #3512816.
This is following the guidance from jQuery documentation:
https://api.jquery.com/jQuery.isFunction/