Fix startup ANR from eager WebView user agent#2156
Merged
Conversation
jocmp
force-pushed
the
jc/2145/lazy-user-agent
branch
3 times, most recently
from
2956681 to
7c65fd6
Compare
WebSettings.getDefaultUserAgent loads the WebView provider, which is slow to initialize on some devices. It was evaluated eagerly inside the AccountManager Koin singleton's initializer, so it ran while holding Koin's single-creation lock. A background thread stalling there blocked the main thread resolving the same singleton, causing startup ANRs (discussion 2145). userAgent is only needed at network time (ArticleContent, FaviconFinder), so it's a () -> String invoked at request time, off the main thread.
jocmp
force-pushed
the
jc/2145/lazy-user-agent
branch
from
7c65fd6 to
2e4bffc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some users hit an ANR on launch the app hangs on the launcher icon then quits. Reported in discussion #2145 but Crashlytics shows it across several devices.
The top ANR issue blames
CommonModule.ktwhich is theAccountManagerKoin singleton initializer. The thread dump:WebSettings.getDefaultUserAgent()loads the WebView/Chromium provider which is slow to initialize.The fix is to lazily resolve the user agent at network time in
ArticleContentandFaviconFinder.Additionally, this moves refresh scheduling off app boot which removes the background thread that was in contention for the singleton lock.