Add DDEV Configuration#32
Conversation
|
|
||
| ## Core Development Using DDEV | ||
|
|
||
| 1. Clone this repository by using `git clone --branch=master https://github.com/bhanu951/drupal-core-development-project.git` |
There was a problem hiding this comment.
This line needs update based upon this PR.
rfay
left a comment
rfay
left a comment
There was a problem hiding this comment.
This seems to be based on a very old DDEV configuration. Please do a ddev config --auto and look at the result and use that.
I would prefer that the many custom commands like nightwatch and phpcs come from one of the other add-ons which is carefully maintained, to avoid conflicts, but understand the convenience of using them here.
Thanks for the effort, please update to current usage, thanks!
| router_https_port: "443" | ||
| xdebug_enabled: false | ||
| additional_hostnames: | ||
| - drupal-core-testing |
There was a problem hiding this comment.
Adding this here means you'll have trouble running more than one project at a time.
There was a problem hiding this comment.
yes, but it makes easier to access phpunit tests output htmls.
| @@ -0,0 +1,11 @@ | |||
| # | |||
| # This file can be used for overriding ENV variables. | |||
There was a problem hiding this comment.
Please put environment variables in the config.yaml (web_environment) instead of this file. Remove this file.
There was a problem hiding this comment.
I think having a separate file makes it's easier for modification. But will remove the file from PR
|
@rfay I was just saying in Slack most of this looks like it belongs in the DDEV for core-dev add-on instead :) |
Co-authored-by: Randy Fay <randy@randyfay.com>
Yup was using it from long time havent updated it recently , ran
I like to have them in this repo itself which makes all the required tools for core development available at one place. @rfay updated the PR with suggested changes please have a look into it again. To jog your memory to recall earlier discussion old PR of same changes |
3 participants
No description provided.