Windows support and Travis CI#47
Open
Gogowitsch wants to merge 2 commits into
Open
Conversation
added 2 commits
February 25, 2019 20:05
PHP internally uses cmd.exe to execute any external process, even when dorgflow is started from Bash. This means we cannot use single quotes mid-argument. Also, we cannot use the ^ character without quotes. As Travis CI shows, it still works under Linux.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds Windows support (details in the commit message).
To prove that I didn't destroy Linux support on the way, I manually tested things and added Travis CI coverage to my fork of this repo. See https://travis-ci.com/Fonata/dorgflow/builds/102212670 for some test output.
@joachim-n If you decide to merge this, you probably have to allow Travis to access your repo. It will set up a hook automatically to run unit tests on each push and each pull request.