Skip to content

Initial submission of assignment 2#3

Open
jnahmiach wants to merge 5 commits into
mainfrom
assignment-2
Open

Initial submission of assignment 2#3
jnahmiach wants to merge 5 commits into
mainfrom
assignment-2

Conversation

@jnahmiach

@jnahmiach jnahmiach commented May 25, 2026

Copy link
Copy Markdown
Owner

UofT-DSI | LCR - Assignment 2

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Initial submission of assignment 2

What did you learn from the changes you have made?

Linear regression

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

Some challenges getting the arrays in the right form to create the slope and intercept df.
For corrections, challenges with train test split.

How were these changes tested?

all cells tested in jupyter notebook to confirm outputs were as expected.

Checklist

  • I can confirm that my changes are working as intended

@KasraVakiloroayaei KasraVakiloroayaei left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A2: Incomplete

Q2, part I: Displacement vs MPG is a negative association. Please verify the remaining associations are correct.
Q3: Please follow the instructions on which parameters should be included in the model and recalculate, to find the correct parameter coefficients and respective intercept value.
Q4. Recalculate after re-doing Q3

@jnahmiach

Copy link
Copy Markdown
Owner Author

@KasraVakiloroayaei confirming corrections have been made.

Q2 p1: corrected Displacement answer and verified other responses

Q3: adjusted to add y_train and y_test
Q4: recalculated with new parameters

@KasraVakiloroayaei KasraVakiloroayaei left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A2: Incomplete

Good work with Q3, although recall that we are interested in numeric predictors only, thus float or integer types of data.

Also your Q4 had an error. please see below:

Image

@jnahmiach

Copy link
Copy Markdown
Owner Author

Thanks @KasraVakiloroayaei,

Q3 edited to select columns using select_dtypes on int and float instead of using names.

Q4 is now running correctly.

@KasraVakiloroayaei KasraVakiloroayaei left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A2: Complete

Great work making suggested changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants