Enhance mfj-226 example by adding support for CSV and Touchstone output formats.#1
Open
fthain wants to merge 1 commit into
Open
Enhance mfj-226 example by adding support for CSV and Touchstone output formats.#1fthain wants to merge 1 commit into
fthain wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Jussi
I created these changes to get my MFJ-226 working with my Linux system. There is no decent software for the MFJ-226 besides libmeas (IMO). Thanks for redeeming my MFJ-226!
The main difficulty I had with the libmeas/example/mfj226 code was the output format. I really need Touchstone format so I can import the data into a SimNEC model. So this patch adds that output format.
sweep.c is not a new file, it's just an enhanced version of swr.c. I renamed it because I wanted a more descriptive name. I assume that this is okay given that swr.c appears to be sample code...
Anyway, I hope you approve of the general direction of this enhancement. I think it might be helpful to other MFJ-226 users.
Please let me know if the patch needs any changes to bring it up to scratch.
Regards
Finn