feat: permission_request timeout + session_timeout event + frontend dismiss#454
Open
jlunder00 wants to merge 1 commit into
Open
feat: permission_request timeout + session_timeout event + frontend dismiss#454jlunder00 wants to merge 1 commit into
jlunder00 wants to merge 1 commit into
Conversation
…end dismiss
A — PermissionGate raises PermissionTimeoutError after 900s (configurable via
agent_layer.permission_timeout_seconds; default bumped from 60→900).
PermissionTimeoutError carries request_id for downstream event attribution.
B — _handle_control_request catches PermissionTimeoutError, sends deny to pool,
re-raises. run_turn catches it, emits {type: session_timeout, session_id,
reason: permission_timeout, request_id} on WebSocket, then ends cleanly.
C — Frontend: session_timeout event added to WsIncomingEvent type. Chat store
handles it by clearing pendingPermissionRequest/permissionQueue, setting
sessionTimedOut flag, and returning without sending permission_response.
BotChat.vue shows "Session timed out — send a message to resume" on timeout.
PermissionModal.vue 60s timer now dismisses to a compact waiting indicator
(Option C) instead of auto-denying — backend is sole timeout authority.
Part D (read_out_of_scope mid-execution permission emission) deferred — requires
cross-process permission protocol design (MCP server and PermissionGate are in
separate processes).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Wire the 15-minute permission request timeout end-to-end across the PermissionGate, session event stream, and frontend.
Parts implemented
A — PermissionGate timeout (permissions.py)
PermissionTimeoutErrorraised (not silent deny) when user doesn't respond within timeoutagent_layer.permission_timeout_secondsrequest_idfor downstream event attributionpermission_pendingstill cleaned up viafinallyblock even when raisingB — session_timeout event (session.py)
_handle_control_requestcatchesPermissionTimeoutError, sendsdenyto pool before re-raisingrun_turncatches it, emits{type: session_timeout, session_id, reason: permission_timeout, request_id}on WebSocket, then ends the generator cleanlyC — Frontend (chat.ts, PermissionModal.vue, BotChat.vue, types/chat.ts)
session_timeoutadded toWsIncomingEventunion typependingPermissionRequest/permissionQueue, setssessionTimedOut = true, does not callsendRaw(backend already denied)BotChat.vue: shows "Session timed out — send a message to resume" whensessionTimedOutPermissionModal.vue: 60s timer now dismisses the modal to a compact "Waiting on your response" indicator instead of auto-denying — backend is the sole timeout authority (Option C)Tests
test_permissions.py+test_session.py)PermissionModal.test.ts, 5 new inchat.test.ts)Deferred
Part D (read_out_of_scope mid-execution permission emission) deferred — requires cross-process permission protocol design. The MCP server and PermissionGate run in separate OS processes; mid-execution permission requests cannot be emitted via the current
can_use_toolpre-check mechanism. Needs its own spec and task.