feat(localization): add Simplified Chinese support#17
Open
131122syy-cloud wants to merge 1 commit into
Open
Conversation
Owner
|
svaka čast!! |
Author
|
Thank you! Glad to contribute. Happy to adjust anything if needed. |
Owner
|
thanks for your support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds Simplified Chinese (
zh-Hans) localization for Reframed, including app metadata, permissions UI, toolbar/settings/export/editor labels, history descriptions, and common status/error strings.Why
This makes Reframed usable for Simplified Chinese users and lets macOS select the Chinese UI automatically when the system language is set to Simplified Chinese.
How
zh-Hans.lproj/Localizable.stringsandzh-Hans.lproj/InfoPlist.stringszh-Hansin the Xcode projectLocalizedStringKeywhere neededTesting
make formatgit diff --check origin/main...HEADplutil -lint Reframed/zh-Hans.lproj/Localizable.strings Reframed/zh-Hans.lproj/InfoPlist.strings Reframed.xcodeproj/project.pbxprojswiftc -frontend -parseon changed Swift filesmake buildcould not be run locally because this machine only has Command Line Tools installed, not full Xcode.