fix: use COPY heredoc in GNOME 48-50 Dockerfiles (fixes broken image builds) - #3
Open
jeevesforjoel wants to merge 1 commit into
Open
fix: use COPY heredoc in GNOME 48-50 Dockerfiles (fixes broken image builds)#3jeevesforjoel wants to merge 1 commit into
jeevesforjoel wants to merge 1 commit into
Conversation
RUN cat > /path <<'EOF' is misinterpreted when the dockerfile:1.4 syntax parser is active — the parser treats the shell heredoc as a Dockerfile heredoc and reads subsequent lines as Dockerfile instructions, causing 'unknown instruction: GSK_RENDERER=cairo'. Fix: use `COPY <<'EOF' /path` (the correct Dockerfile 1.4 syntax for writing file content) instead of cat+heredoc inside RUN. Also adds the # syntax=docker/dockerfile:1.4 directive to gnome-shell-49-x11 which was missing it. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The weekly image build CI has been failing for
gnome-shell-48,gnome-shell-49,gnome-shell-49-x11, andgnome-shell-50since they were added (run 29232568352):Root cause
All four Dockerfiles use the dockerfile:1.4 syntax directive, then write a wrapper script via a shell heredoc inside
RUN:With the
dockerfile:1.4syntax parser active, the<<'EOF'inside aRUNcommand is interpreted as a Dockerfile-level heredoc, not a shell heredoc. The parser then reads#!/bin/shandGSK_RENDERER=cairoas Dockerfile instructions, causing the parse error.Fix
Replace
RUN cat > /path <<'EOF'withCOPY <<'EOF' /path— the correct Dockerfile 1.4 syntax for writing file content inline.Also adds the missing
# syntax=docker/dockerfile:1.4directive tognome-shell-49-x11.Dockerfile.This unblocks the
soft-brightness-plusE2E tests for GNOME 48/49/50, which pull these images fromghcr.io/jkitching/.