Undefine the allocator for Patricia to prevent warnings - #1
Open
tedaford wants to merge 2 commits into
Open
Conversation
Owner
|
+Eric Wong +Tatsuya Mori in an email thread (I couldn't find your email,
Ted).
Ages ago I had cloned (uploaded?) this repo to GitHub and made a few
changes. As far as I can tell, the official repo is hosted by Eric here:
https://yhbt.net/rpatricia.git/
My cloned repo and the official one have diverged slightly, since I had
bumped the version number.
Ted, it might make more sense for you to offer this patch to Eric Wong and
Tatsuya Mori. Their emails are in the README file.
Eric Wong and Tatsuya Mori, feel free to reply on the GitHub pull request
directly, or respond here and I will let Ted know your response.
Thanks! =)
…On Tue, Sep 10, 2024 at 12:23 AM Ted Ford ***@***.***> wrote:
This should allow Ruby 3.3.x compatibility
------------------------------
You can view, comment on, or merge this pull request online at:
#1
Commit Summary
- 7a8e619
<7a8e619>
Undefine the allocator for Patricia to prevent warnings
File Changes
(1 file <https://github.com/jkitching/rpatricia/pull/1/files>)
- *M* ext/rpatricia/rpatricia.c
<https://github.com/jkitching/rpatricia/pull/1/files#diff-db112c7a0c2af0cb5c9c12a46fcab7826263aeaea676442330a7e770af742eba>
(3)
Patch Links:
- https://github.com/jkitching/rpatricia/pull/1.patch
- https://github.com/jkitching/rpatricia/pull/1.diff
—
Reply to this email directly, view it on GitHub
<#1>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD5RFZXDIFFY6KOBZ4MCMLZVXDONAVCNFSM6AAAAABN4463X2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGUYTIMZYHA2DSNI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
In case anyone else runs into this through google, this should read rb_undef_alloc_func(cNode);
|
Author
|
PR updated per your suggestion @Roguelazer , you seem to know a bit more about the underlying |
tedaford
marked this pull request as ready for review
June 10, 2025 20:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should allow Ruby 3.3.x compatibility