fix: scan zip entries in determine_package_type instead of assuming index 1#100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zip entry order isn't guaranteed and directory entries are optional, so
hardcoding entry index 1 as the inner
Payload/<name>.{app,bundle}/folderbreaks for archives whose writers omit directory entries or order entries
differently. Scan the central directory for any path under
Payload/whosetop segment carries the expected extension. Also defer
get_bundle_idtothe
.appbranch so IPCC packages without a depth-3 Info.plist no longerfail detection.