fix: improve performance of ReportTask/CheckLicense on projects with many modules - #405
Merged
Merged
Conversation
chadlwilson
force-pushed
the
fix-perf-regression
branch
from
June 10, 2026 15:46
252a7a3 to
d01cf31
Compare
…many modules The changes in 53f9c37 and 3048739 accidentally ended up doing quadratic re-resolution of projects and dependencies before de-duplicating the data. This change fixes that, and further improves the cache key resolution to only resolve dependencies without processing their POMs, manifests etc. It also refactors the logic to be appropriately reused across ProjectReader/ConfigurationReader etc.
chadlwilson
force-pushed
the
fix-perf-regression
branch
from
June 10, 2026 15:49
d01cf31 to
f1b2902
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in 53f9c37 and 3048739 accidentally ended up doing quadratic re-resolution of projects and dependencies before de-duplicating the data, while determining the
@Inputcache key.This change fixes that, and further improves the cache key resolution to only resolve dependencies without processing their POMs, manifests etc. It also refactors the logic to be appropriately reused across
ProjectReader/ConfigurationReaderetc to reduce the chance of such issues and make it a little easier to refactor things towards safer project access (which this project currently does not do)