cli: log: resolve query intersected with prioritize expression independently - #9979
Open
yuja wants to merge 3 commits into
Open
cli: log: resolve query intersected with prioritize expression independently#9979yuja wants to merge 3 commits into
yuja wants to merge 3 commits into
Conversation
Since at_operation() creates a resolution scope, the WithinReference node
shouldn't be omitted even if no referenced commits exist in it. It prevents
outer referenced commits from being propagated to the inner node:
at_operation(op, all()) & outer_ref
-----
shouldn't include outer_ref
…ndently Alternatively, we could insert a WithinVisibility node by resolve_user_expression(). It works, but it can prevent optimization. Fixes #9975
josephlou5
reviewed
Aug 13, 2026
| ); | ||
|
|
||
| // Visibility and referenced commits resolution between sub expressions: | ||
| // each at_operation() node should create its own scope. |
Contributor
There was a problem hiding this comment.
Is the "Since at_operation(op, x) brings all commits that were visible at the operation to the search space" text at https://docs.jj-vcs.dev/latest/revsets/#functions now inaccurate? There was some confusion around this wording in the Discord.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9975
Checklist
If applicable:
CHANGELOG.mdREADME.md,docs/,demos/)cli/src/config-schema.json)how it works, how it's organized), including any code drafted by an LLM.
an eye towards deleting anything that is irrelevant, clarifying anything
that is confusing, and adding details that are relevant. This includes,
for example, commit descriptions, PR descriptions, and code comments.