move RepoPathUiConverter to separate module - #9893
Conversation
I'm about to move this type to a new module and would like the new module to not have `#![expect(missing_docs)]` in the new module.
The `RepoPathUiConverter` type should perhaps not be moved to the coming `jj-core` crate, so this patch prepares for moving `RepoPath` to the crate without leaving a `repo_path` module without `RepoPath` behind.
yuja
left a comment
yuja
left a comment
There was a problem hiding this comment.
The
RepoPathUiConvertertype should perhaps not be moved to the comingjj-corecrate,
Splitting modules makes sense, but I'm not sure about this. If we're going to move revsets and filesets to jj-core, we'll also need to move some form of parse_file_path(str) -> RepoPath interface.
| } | ||
|
|
||
| #[test] | ||
| fn test_split_common_prefix() { |
There was a problem hiding this comment.
This test shouldn't be moved to ui_path.rs.
|
I figured we'd move revsets and filesets but that we would try to leave the parsing functions in |
|
3 participants
Checklist
If applicable:
CHANGELOG.mdREADME.md,docs/,demos/)cli/src/config-schema.json)how it works, how it's organized), including any code drafted by an LLM.
an eye towards deleting anything that is irrelevant, clarifying anything
that is confusing, and adding details that are relevant. This includes,
for example, commit descriptions, PR descriptions, and code comments.