meta: Extract revset parser as a separate crate - #9739
Conversation
cb4f32c to
ceccabd
Compare
Why can you not depend on |
|
I am trying to compile the revset parser to wasm, which I am unable to do for |
|
You could use the tree-sitter parser. It should be able to handle text with syntax errors better (if that matters). |
|
This also is conflicting with my |
yes, building the library with |
|
@PhilipMetzger If everything in this PR can be moved to |
|
I'm not sure if the whole revset modules will be moved to |
|
#9766 moved all of these into core. |
I am working on a VSCode plugin and extracting the revset parser is needed for it. So, I submitted this PR. There were a few things I couldn't decide:
The following don't probably belong in
jj_revset_parsercrate, but it needs them:content_hash.rs(and thus the proc_macro was changed)ref_name.rsfmt.rs(extracted fromlib/src/revset.rs)Checklist
If applicable:
CHANGELOG.mdREADME.md,docs/,demos/)cli/src/config-schema.json)how it works, how it's organized), including any code drafted by an LLM.
an eye towards deleting anything that is irrelevant, clarifying anything
that is confusing, and adding details that are relevant. This includes,
for example, commit descriptions, PR descriptions, and code comments.