Add flag to push to gerrit with no-change-id - #9387
Draft
DanieleSassoli wants to merge 1 commit into
Draft
Conversation
There was a problem hiding this comment.
The following commits do not follow our format for subject lines:
- 10a4d1f: Add flag to push to gerrit with no-change-id
Commits should have a subject line following the format <topic>: <description>. Please review the commit guidelines for more information.
DanieleSassoli
marked this pull request as draft
April 26, 2026 17:51
DanieleSassoli
force-pushed
the
gerrit-no-change-id
branch
from
August 14, 2026 16:40
d952be6 to
a40a38b
Compare
As Gerrit moves towards natively supporting JJ style change-ids, there should be an option to push to gerrit without adding a Gerrit change-id footer. For now support in Gerrit is not yet merged, therefore by default we should still add it. Once Gerrit support JJ change-ids natively, we can switch the logic so that by default JJ doesn't add it.
DanieleSassoli
force-pushed
the
gerrit-no-change-id
branch
from
August 14, 2026 16:52
a40a38b to
10a4d1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As Gerrit moves towards natively supporting JJ style change-ids, there should be an option to push to gerrit without adding a Gerrit change-id footer. For now support in Gerrit is not yet merged, therefore by default we should still add it.
Once Gerrit support JJ change-ids natively, we can switch the logic so that by default JJ doesn't add it.
Checklist
If applicable:
CHANGELOG.mdREADME.md,docs/,demos/)cli/src/config-schema.json)how it works, how it's organized), including any code drafted by an LLM.
an eye towards deleting anything that is irrelevant, clarifying anything
that is confusing, and adding details that are relevant. This includes,
for example, commit descriptions, PR descriptions, and code comments.