Skip to content

Add flag to push to gerrit with no-change-id - #9387

Draft
DanieleSassoli wants to merge 1 commit into
jj-vcs:mainfrom
DanieleSassoli:gerrit-no-change-id
Draft

Add flag to push to gerrit with no-change-id#9387
DanieleSassoli wants to merge 1 commit into
jj-vcs:mainfrom
DanieleSassoli:gerrit-no-change-id

Conversation

@DanieleSassoli

Copy link
Copy Markdown
Contributor

As Gerrit moves towards natively supporting JJ style change-ids, there should be an option to push to gerrit without adding a Gerrit change-id footer. For now support in Gerrit is not yet merged, therefore by default we should still add it.

Once Gerrit support JJ change-ids natively, we can switch the logic so that by default JJ doesn't add it.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added/updated tests to cover my changes
  • I fully understand the code that I am submitting (what it does,
    how it works, how it's organized), including any code drafted by an LLM.
  • For any prose generated by an LLM, I have proof-read and copy-edited with
    an eye towards deleting anything that is irrelevant, clarifying anything
    that is confusing, and adding details that are relevant. This includes,
    for example, commit descriptions, PR descriptions, and code comments.

@DanieleSassoli
DanieleSassoli requested a review from a team as a code owner April 26, 2026 17:51

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following commits do not follow our format for subject lines:

  • 10a4d1f: Add flag to push to gerrit with no-change-id

Commits should have a subject line following the format <topic>: <description>. Please review the commit guidelines for more information.

@DanieleSassoli
DanieleSassoli marked this pull request as draft April 26, 2026 17:51
As Gerrit moves towards natively supporting JJ style change-ids, there
should be an option to push to gerrit without adding a Gerrit change-id
footer. For now support in Gerrit is not yet merged, therefore by
default we should still add it.

Once Gerrit support JJ change-ids natively, we can switch the logic so
that by default JJ doesn't add it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant