[F팀 김태호] 백엔드 API 과제 제출 - #5
Open
taeho4523 wants to merge 1 commit into
Open
Conversation
jinu0328
reviewed
Dec 2, 2024
Owner
There was a problem hiding this comment.
스웨거 연동까지 해주셨군요 👍
스웨거 설정에 jwt 적용 설정까지 해주셨는데 처음 기획이 인증 인가까지 구현해주시려고 했던 걸까요? ㅎㅎ
Owner
There was a problem hiding this comment.
API 응답의 ResponseEntity 구조가 거의 동일하게 반복되고 있습니다. status, message, data를 사용하는 구조를 반복적으로 작성하는 대신, 이를 하나의 공통 응답 객체로 관리하면 코드의 재사용성과 가독성을 크게 향상시킬 수 있을 것 같습니다. 현재 main 브랜치에도 그러한 방식으로 코드가 작성되어있으니 참고해주시면 좋을 것 같습니다! 👍
Owner
There was a problem hiding this comment.
from 메서드를 통해 엔티티 객체를 정적으로 응답dto로 변환하신 점 좋습니다 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.