feat: centralize schema ux templates - #35
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR centralizes JSON Schema-driven placeholder/template generation into a shared utility so both the schema-based form UI and the plugin JSON editor generate consistent “minimal valid” templates from the same rules.
Changes:
- Added
schemaTemplate.tsutility to generate templates/placeholders and apply schema defaults acrossoneOf/anyOf,if/then, and required fields. - Updated
SchemaFormandPluginEditorDrawerto reuse the shared placeholder/template logic. - Added Playwright regression coverage for union required fields, conditional requirements, and required array items; added a schema UX TODO checklist doc.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/schema-form/schemaTemplate.ts | New shared JSON Schema template/default/placeholder utilities. |
| src/components/schema-form/SchemaForm.tsx | Reuses centralized placeholder logic for schema form defaults. |
| src/components/form-slice/FormItemPlugins/PluginEditorDrawer.tsx | Switches plugin JSON templating/defaulting to shared utility. |
| e2e/tests/schema-template.spec.ts | New regression tests for template generation edge cases. |
| docs/design/schema-ux-todo.md | Adds a checklist documenting remaining schema-driven UX gaps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+165
to
+170
| if (type === 'array') { | ||
| if (resolvedSchema.minItems && resolvedSchema.minItems > 0 && resolvedSchema.items) { | ||
| return [placeholderForJsonSchema(resolvedSchema.items, rootSchema)]; | ||
| } | ||
| return []; | ||
| } |
Comment on lines
+92
to
+98
| if (isRecord(base[key]) && hasSchemaProperties(propSchema)) { | ||
| base[key] = applyJsonSchemaDefaults( | ||
| propSchema, | ||
| base[key] as Record<string, unknown>, | ||
| root | ||
| ); | ||
| } |
Comment on lines
+227
to
+232
| if (isRecord(value) && propSchema) { | ||
| const resolvedPropSchema = getResolvedSchema(propSchema, root); | ||
| if (hasSchemaProperties(resolvedPropSchema)) { | ||
| base[key] = buildJsonSchemaTemplate(resolvedPropSchema, value, root); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification