fix(maven): avoid overriding existing sonar properties#32637
Open
yuliuyi717-ux wants to merge 4 commits intojhipster:mainfrom
Open
fix(maven): avoid overriding existing sonar properties#32637yuliuyi717-ux wants to merge 4 commits intojhipster:mainfrom
yuliuyi717-ux wants to merge 4 commits intojhipster:mainfrom
Conversation
4e7d9a8 to
2320f58
Compare
Contributor
Author
|
Rebased this branch onto the latest Current run result:
PR diff is limited to the java-simple code-quality generator (adding If possible, could a maintainer rerun the failed jobs? |
2320f58 to
2a1b91c
Compare
Contributor
Author
|
Quick update: I retriggered a fresh CI run on the latest branch head, and all checks are now green on this PR. The previously failing matrix jobs also passed in this run:
Please let me know if you’d like any follow-up changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change avoids noisy Maven warnings caused by
properties-maven-pluginoverriding properties already defined in the POM duringinitialize.What changed
<override>false</override>to the generatedproperties-maven-pluginconfiguration injava-simple-application:code-quality.override=false.Why
When reproducing the issue context from #22487 on current
main, plugin-validation warnings are no longer reproducible with current plugin versions, but the generated build still emits a large amount of property-clash warnings fromproperties-maven-plugin.This patch reduces that warning noise while keeping sonar property loading in place.
Refs #22487
Validation