-
Notifications
You must be signed in to change notification settings - Fork 0
21 questions #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
21 questions #3
Changes from all commits
4d97e86
15c6170
51645b2
7ddbbf6
be9300b
b768da7
839babc
e69e8a3
4e951a8
199d504
fdd4d49
82098f7
4d2ebc3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,4 +9,57 @@ dist | |
| *.wasm | ||
| *.wasm.map | ||
| *.wasm.d.ts | ||
| *.wasm.d.ts.map | ||
| *.wasm.d.ts.map | ||
|
|
||
| packages/plugin-filecoin/filecoin-rs/target | ||
|
|
||
| # Ignore Cargo.lock and target directories for Rust projects | ||
| Cargo.lock | ||
| target | ||
|
|
||
| # Ignore IntelliJ IDEA Rust plugin files | ||
| .idea/rust/ | ||
|
|
||
| # Ignore VSCode Rust extension settings | ||
| .vscode/settings.json | ||
|
|
||
| # Ignore Rust-generated files | ||
| *.rs.bk | ||
| *.rs.old | ||
| *.rs.swp | ||
| node_modules | ||
| dist | ||
| *.log | ||
| *.swp | ||
| .vscode/ | ||
| .idea/ | ||
|
|
||
|
Comment on lines
+30
to
+36
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Duplicate ignore entries detected. The rules for |
||
| # Ignore build artifacts | ||
| *.wasm | ||
| *.wasm.map | ||
| *.wasm.d.ts | ||
| *.wasm.d.ts.map | ||
|
|
||
|
Comment on lines
+37
to
+42
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Duplicate build artifact ignore rules for WebAssembly files. The build artifact entries ( |
||
| packages/plugin-filecoin/filecoin-rs/target | ||
|
|
||
|
Comment on lines
+43
to
+44
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Duplicate target directory ignore for filecoin-rs. The entry for |
||
| # Ignore Cargo.lock and target directories for Rust projects | ||
| Cargo.lock | ||
| target | ||
|
|
||
|
Comment on lines
+45
to
+48
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Duplicate Cargo.lock and target ignores for Rust projects. These rules, which ignore |
||
| # Ignore IntelliJ IDEA Rust plugin files | ||
| .idea/rust/ | ||
|
|
||
|
Comment on lines
+49
to
+51
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Duplicate IntelliJ IDEA Rust plugin ignore entry. The |
||
| # Ignore VSCode Rust extension settings | ||
| .vscode/settings.json | ||
|
|
||
|
Comment on lines
+52
to
+54
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Duplicate VSCode Rust extension settings ignore entry. The entry |
||
| # Ignore Rust-generated files | ||
| *.rs.bk | ||
| *.rs.old | ||
| *.rs.swp | ||
|
|
||
|
Comment on lines
+55
to
+59
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Duplicate Rust-generated files ignore rules. The backup and temporary file rules ( |
||
|
|
||
|
|
||
|
|
||
| # Include node and python | ||
| node_modules | ||
| venv | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Fix Command Chaining in the UI Setup Script
The newly added script
"setup:start:ui"currently reads as:This command is missing an
&&between the directory change (cd packages/plugin-filecoin/) and the execution ofpnpm run tauri run. Without the additional&&, the shell will interpretpnpmas an argument to thecdcommand, which results in a syntax error.Please update it as follows: