fix: check failing if coordinate is 0 - #13
Open
andrezz-b wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After saving a model which has an element with a coordinate set to 0 the loading of that model will fail. This is because the 0 is treated as a falsy value in
addLoadedElementand the if condition is not satisfied.In my case a dependum had a coordinate 0 and was set left on
undefined, then the loading crashed infileManager.js:348when accessingdependum.typeand the dependum is not defined.Fix
Use
typeofto explicitly check that x and y are numbers.