build(deps-dev): patch js-yaml and @babel/core advisories#188
Closed
adrianschmidt wants to merge 1 commit into
Closed
build(deps-dev): patch js-yaml and @babel/core advisories#188adrianschmidt wants to merge 1 commit into
adrianschmidt wants to merge 1 commit into
Conversation
Add scoped overrides to resolve two security advisories in dev-only transitive dependencies: - @babel/core -> ^7.29.6 (arbitrary file read via sourceMappingURL, low): fully resolved. - js-yaml@^4 -> ^4.2.0 (quadratic-complexity DoS in merge-key handling, GHSA-h67p-54hq-rp68, moderate): resolves the eslint, @eslint/eslintrc and puppeteer copies. The remaining js-yaml@3.14.2 is required as ^3 by @istanbuljs/load-nyc-config (jest coverage tooling). It cannot move to 4.x without a major jest downgrade, and only parses the local .nycrc config (not attacker-controlled), so that copy is left in place. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Patches two security advisories in dev-only transitive dependencies via scoped
overridesinpackage.json:@babel/core— arbitrary file read viasourceMappingURL7.29.7js-yaml— quadratic-complexity DoS in merge-key handling (GHSA-h67p-54hq-rp68)js-yaml@4copies (eslint,@eslint/eslintrc,puppeteer) →4.3.0Why
overridesinstead ofnpm audit fixnpm audit fixpulled in dozens of unrelated cross-platformsass-embedded/rollupoptional binaries and bumped unrelated packages. The scoped overrides keep the change limited to the affected packages and pin the safe versions so a future install can't regress them.Known residual:
js-yaml@3.14.2One
js-yaml@3.14.2copy remains and cannot be fixed here. It is required as^3by@istanbuljs/load-nyc-config(jest coverage tooling); the fix only exists injs-yaml@4.2.0, a breaking major bump. npm's only offered remedy is downgrading jest to 25.0.0 (major, breaking).Practical risk is negligible: that copy only parses the local
.nycrcconfig during coverage runs, which is not attacker-controlled.Scope
Dev dependencies only — no change to shipped runtime code.
🤖 Generated with Claude Code